ashb commented on PR #22867: URL: https://github.com/apache/airflow/pull/22867#issuecomment-1094103558
> A few general questions: > 1. Should we say something about trigger rules? I guess if one of the items in mapped task fails than the whole task fails? This may open a big window of how trigger rules should work. Conceptually at a high level. The way it's implemented all upstream TaskInstances (mapped or not) are counted - so a task downstream of a mapped task is like having n upstreams to check in trigger rules. > 2. Referring to question 1... "one of the items in mapped task fails" is very long. Should we come up with an easy simple name so speak of a specific instance in a maped task? "Mapped task instance" is what we use in the code for this > 3. This doc demonstrate a case where a list was pushed to Xcom and then we generate a mapped task from it to parse it. What happens if user wants to push to Xcom in the mapped task? Before the API - the key would be the task_id. What it will be now? It now also includes map_index (default of -1 to mean not mapped. PK cols can't be null, so we had to go with -1) Pushing from a mapped task instance is shown (implicitly via return values) in the Repeated Mapping example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
