jedcunningham commented on code in PR #22913:
URL: https://github.com/apache/airflow/pull/22913#discussion_r848528863


##########
chart/templates/scheduler/scheduler-deployment.yaml:
##########
@@ -243,10 +243,10 @@ spec:
         {{- else if .Values.dags.gitSync.enabled }}
         - name: dags
           emptyDir: {}
-        {{- end }}
         {{- if and  .Values.dags.gitSync.enabled  
.Values.dags.gitSync.sshKeySecret }}

Review Comment:
   ```suggestion
           {{- if .Values.dags.gitSync.sshKeySecret }}
   ```
   
   We are already in a gitsync enabled block.



##########
chart/templates/triggerer/triggerer-deployment.yaml:
##########
@@ -192,10 +192,10 @@ spec:
         {{- else if .Values.dags.gitSync.enabled }}
         - name: dags
           emptyDir: {}
-        {{- end }}
         {{- if and .Values.dags.gitSync.enabled 
.Values.dags.gitSync.sshKeySecret }}

Review Comment:
   ```suggestion
           {{- if .Values.dags.gitSync.sshKeySecret }}
   ```



##########
chart/templates/triggerer/triggerer-deployment.yaml:
##########
@@ -192,10 +192,10 @@ spec:
         {{- else if .Values.dags.gitSync.enabled }}
         - name: dags
           emptyDir: {}
-        {{- end }}
         {{- if and .Values.dags.gitSync.enabled 
.Values.dags.gitSync.sshKeySecret }}

Review Comment:
   ```suggestion
           {{- if .Values.dags.gitSync.sshKeySecret }}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to