uranusjr commented on code in PR #22051:
URL: https://github.com/apache/airflow/pull/22051#discussion_r848828587
##########
airflow/models/dagbag.py:
##########
@@ -492,13 +492,14 @@ def collect_dags(
Given a file path or a folder, this method looks for python modules,
imports them and adds them to the dagbag collection.
- Note that if a ``.airflowignore`` file is found while processing
+ Note that if an ``.airflowignore`` file is found while processing
Review Comment:
For me _a_ is right because `.airflowignore` is prodounced _dot airflow
ignore_.
##########
airflow/config_templates/config.yml:
##########
@@ -233,6 +233,14 @@
type: string
example: ~
default: "True"
+ - name: dag_ignore_file_syntax
+ description: |
+ The pattern syntax used in the ".airflowignore" files in the DAG
directories. Valid values are
+ ``regexp`` or ``glob``.
Review Comment:
```suggestion
The pattern syntax used in the ".airflowignore" files in the DAG
directories. Valid values are
``regexp`` and ``glob``.
```
I think this is correct English? (I’m non-native so don’t take my words)
##########
airflow/models/dagbag.py:
##########
@@ -492,13 +492,14 @@ def collect_dags(
Given a file path or a folder, this method looks for python modules,
imports them and adds them to the dagbag collection.
- Note that if a ``.airflowignore`` file is found while processing
+ Note that if an ``.airflowignore`` file is found while processing
the directory, it will behave much like a ``.gitignore``,
- ignoring files that match any of the regex patterns specified
+ ignoring files that match any of the patterns specified
in the file.
- **Note**: The patterns in .airflowignore are treated as
- un-anchored regexes, not shell-like glob patterns.
+ **Note**: The patterns in .airflowignore are interpreted as either
Review Comment:
```suggestion
**Note**: The patterns in ``.airflowignore`` are interpreted as
either
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
