uranusjr commented on code in PR #22391:
URL: https://github.com/apache/airflow/pull/22391#discussion_r848823157
##########
airflow/providers/amazon/aws/hooks/redshift_sql.py:
##########
@@ -133,3 +135,55 @@ def get_conn(self) -> RedshiftConnection:
conn: RedshiftConnection = redshift_connector.connect(**conn_kwargs)
return conn
+
+ def set_autocommit(self, conn, autocommit: Any) -> None:
+ conn.autocommit = autocommit
+
+ def get_autocommit(self, conn):
+ return getattr(conn, 'autocommit_mode', False)
+
+ def run(
+ self,
+ sql,
+ autocommit: bool = False,
+ parameters: Optional[Union[Sequence[Any], Dict[Any, Any]]] = None,
+ handler: Optional[Callable] = None,
+ ) -> None:
Review Comment:
This return type annotation is wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
