eladkal commented on code in PR #22974:
URL: https://github.com/apache/airflow/pull/22974#discussion_r849447312


##########
airflow/providers/dbt/cloud/example_dags/example_dbt_cloud.py:
##########
@@ -22,7 +22,7 @@
 try:
     from airflow.operators.empty import EmptyOperator as DummyOperator
 except ModuleNotFoundError:
-    from airflow.operators.dummy import DummyOperator
+    from airflow.operators.dummy import DummyOperator  # type: ignore

Review Comment:
   mypy is very picky in this case
   ```
   Run 
mypy.................................................................................Failed
   - hook id: mypy
   - exit code: 1
   
   
airflow/providers/microsoft/azure/example_dags/example_adf_run_pipeline.py:25: 
error:
   Incompatible import of "DummyOperator" (imported name has type
   "Type[DummyOperator]", local name has type "Type[EmptyOperator]")  [misc]
   ```
   
   followed 
https://stackoverflow.com/questions/59037244/mypy-incompatible-import-error-for-conditional-imports
 which recommanded to add `type: ignore` in this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to