potiuk commented on code in PR #22971:
URL: https://github.com/apache/airflow/pull/22971#discussion_r850275338
##########
scripts/tools/initialize_virtualenv.py:
##########
@@ -103,23 +110,24 @@ def main():
"sudo apt install build-essential python3-dev libsqlite3-dev
openssl"
"sqlite default-libmysqlclient-dev libmysqlclient-dev
postgresql"
)
- return
+ sys.exit(4)
print("\nResetting AIRFLOW sqlite database...")
- os.environ["AIRFLOW__CORE__LOAD_EXAMPLES"] = "False"
- os.environ["AIRFLOW__CORE__UNIT_TEST_MODE"] = "False"
- os.environ["AIRFLOW__DATABASE__SQL_ALCHEMY_POOL_ENABLED"] = "False"
- os.environ["AIRFLOW__CORE__DAGS_FOLDER"] = f"{airflow_sources}/empty"
- os.environ["AIRFLOW__CORE__PLUGINS_FOLDER"] = f"{airflow_sources}/empty"
- subprocess.run(["airflow", "db", "reset", "--yes"])
+ env = os.environ.copy()
+ env["AIRFLOW__CORE__LOAD_EXAMPLES"] = "False"
+ env["AIRFLOW__CORE__UNIT_TEST_MODE"] = "False"
+ env["AIRFLOW__DATABASE__SQL_ALCHEMY_POOL_ENABLED"] = "False"
+ env["AIRFLOW__CORE__DAGS_FOLDER"] = f"{airflow_sources}/empty"
+ env["AIRFLOW__CORE__PLUGINS_FOLDER"] = f"{airflow_sources}/empty"
+ subprocess.run(["airflow", "db", "reset", "--yes"], env=env)
print("\nResetting AIRFLOW sqlite unit test database...")
- os.environ["AIRFLOW__CORE__LOAD_EXAMPLES"] = "True"
- os.environ["AIRFLOW__CORE__UNIT_TEST_MODE"] = "False"
- os.environ["AIRFLOW__DATABASE__SQL_ALCHEMY_POOL_ENABLED"] = "False"
- os.environ["AIRFLOW__CORE__DAGS_FOLDER"] = f"{airflow_sources}/empty"
- os.environ["AIRFLOW__CORE__PLUGINS_FOLDER"] = f"{airflow_sources}/empty"
- subprocess.run(["airflow", "db", "reset", "--yes"])
+ env["AIRFLOW__CORE__LOAD_EXAMPLES"] = "True"
Review Comment:
I'd rather start env from scratch for every command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
