FridayPush commented on PR #4341: URL: https://github.com/apache/airflow/pull/4341#issuecomment-1100718236
I appreciate the invitation @potiuk, generally this PR is what I would produce to make the change. I would likely have removed the `template_fields` test as it is a value check. Additionally the [BaseOperator already has tests](https://github.com/apache/airflow/blob/main/tests/models/test_baseoperator.py) that validate the behavior of changes to the `template_fields` Per the original PR review the only template rendering test I can find in other [AWS Operators is the 'batch' operator](https://github.com/apache/airflow/blob/main/tests/providers/amazon/aws/operators/test_batch.py#L100). If I was to submit a new PR with the changes to the template_fields how should tests be handled? Would you lean towards removing the test or adding the per field test referenced by mik-laj? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
