[
https://issues.apache.org/jira/browse/AIRFLOW-3537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523158#comment-17523158
]
ASF GitHub Bot commented on AIRFLOW-3537:
-----------------------------------------
FridayPush commented on PR #4341:
URL: https://github.com/apache/airflow/pull/4341#issuecomment-1100718236
I appreciate the invitation @potiuk, generally this PR is what I would
produce to make the change. I would likely have removed the `template_fields`
test as it is a value check. Additionally the [BaseOperator already has
tests](https://github.com/apache/airflow/blob/main/tests/models/test_baseoperator.py)
that validate the behavior of changes to the `template_fields`
Per the original PR review the only template rendering test I can find in
other [AWS Operators is the 'batch'
operator](https://github.com/apache/airflow/blob/main/tests/providers/amazon/aws/operators/test_batch.py#L100).
If I was to submit a new PR with the changes to the template_fields how
should tests be handled? Would you lean towards removing the test or adding the
per field test referenced by mik-laj?
> Allow AWS ECS Operator to use templates in task_definition parameter
> --------------------------------------------------------------------
>
> Key: AIRFLOW-3537
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3537
> Project: Apache Airflow
> Issue Type: Wish
> Components: aws
> Reporter: tomoya tabata
> Assignee: tomoya tabata
> Priority: Minor
>
> The AWS ECS operator does not currently apply templates to the
> task_definition parameter.
> I'd like to allow AWS ECS Operator to use templates in task_definition
> parameter.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
