jedcunningham commented on code in PR #23137:
URL: https://github.com/apache/airflow/pull/23137#discussion_r855853423
##########
airflow/configuration.py:
##########
@@ -271,7 +271,7 @@ def __init__(self, default_config=None, *args, **kwargs):
if default_config is not None:
self.airflow_defaults.read_string(default_config)
# Set the upgrade value based on the current loaded default
- default = self.airflow_defaults.get('logging',
'log_filename_template', fallback=None, raw=True)
+ default = self.airflow_defaults.get('logging',
'log_filename_template', fallback=None)
Review Comment:
Since we now set an env var, we want the `parsed` value, not the `raw`
value. Otherwise we end up with `%%`'s instead of the `%`'s that jinja is
expecting.
I feel like there might be more landmines in this are (configparser vs env
var when shoving these back into env vars always), but this at least fixes this
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
