tanelk commented on code in PR #23181:
URL: https://github.com/apache/airflow/pull/23181#discussion_r856590083
##########
tests/jobs/test_local_task_job.py:
##########
@@ -799,6 +800,121 @@ def
test_mini_scheduler_works_with_wait_for_upstream(self, caplog, dag_maker):
assert failed_deps[0].dep_name == "Previous Dagrun State"
assert not failed_deps[0].passed
+ @pytest.mark.parametrize(
+ "exception, trigger_rule",
+ [
+ (AirflowFailException(), TriggerRule.ALL_DONE),
+ (AirflowFailException(), TriggerRule.ALL_FAILED),
+ (AirflowSkipException(), TriggerRule.ALL_DONE),
+ (AirflowSkipException(), TriggerRule.ALL_SKIPPED),
+ (AirflowSkipException(), TriggerRule.NONE_FAILED_MIN_ONE_SUCCESS),
+ ],
+ )
+ @conf_vars({('scheduler', 'schedule_after_task_execution'): 'True'})
+ def test_mini_scheduler_works_with_skipped_and_failed(self, exception,
trigger_rule, caplog, dag_maker):
Review Comment:
These pass even without the PR - initially tried to recreate the issue with
these, but now left just to improve coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
