potiuk opened a new pull request, #23189: URL: https://github.com/apache/airflow/pull/23189
This is an aftermath of #23104 after switchig to docs building by breeze, failure of build documentation did not trigger failure of the docs build (but it did trigger main failure of pushing the documentation). This change improves and simplifies the return code processing and propagation in the commands executed by breeze - thanks to common returncode, stdout, stderr available in both CompletedProcess and CalledProcessError and returning fake CompletedProcess in dry_run mode, we can also satisfy MyPy type check by returning non-optional Union of those two types which simplifies returncode processing. This change fixes the error in the docs (lack of empty lines before auto-generated extras). All commands have been reviewed to see if the returncode is correctly handled where needed. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
