potiuk commented on PR #23215:
URL: https://github.com/apache/airflow/pull/23215#issuecomment-1108503081
> But that message (or an exception) could be printed in the base class
instead so that all database providers share this logic.
And we have to remember about compatibility with providers. We cannot rely
on DBApi being present in the same version DBApi is part of the core - so the
right way of introducing the change is to add it in the provider (and possibly
add it in DBApi for the future but it cannot be reiled upon until
min-compatibility is reached.
DBApiHook is quite special because of that and even has this note:
```
#########################################################################################
#
#
# Note! Be extra careful when changing this file. This hook is used as a
base for #
# a number of DBApi-related hooks and providers depend on the methods
implemented #
# here. Whatever you add here, has to backwards compatible unless
#
# `>=<Airflow version>` is added to providers' requirements using the new
feature #
#
#
#########################################################################################
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
