potiuk commented on code in PR #23105:
URL: https://github.com/apache/airflow/pull/23105#discussion_r857901076
##########
airflow/models/connection.py:
##########
@@ -278,16 +287,10 @@ def password(cls):
"""Password. The value is decrypted/encrypted when reading/setting the
value."""
return synonym('_password', descriptor=property(cls.get_password,
cls.set_password))
- def get_extra(self) -> Dict:
+ def get_extra(self) -> Optional[str]:
Review Comment:
But @dstandish recently implemented changes where extra_dejson is just left
for compatibility but extra is supposed to be Dict - and whenever we see it is
a string it will raise deprecation warnings.
https://github.com/apache/airflow/pull/21816
With the Airflow 3.0 vision that only Dict will be allowed.
But I agree `extra_dejson` suspiciously assume that extra is a string and I
think it is used in a number of places - so possibly it should be corrected
even for 2.3.0 (and some `if "str" else assume dict and return it` should be
implemented? @dstandish ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
