dstandish commented on a change in pull request #5372: [AIRFLOW-3057] add
prev_*_date_success to template context
URL: https://github.com/apache/airflow/pull/5372#discussion_r291323721
##########
File path: airflow/models/taskinstance.py
##########
@@ -528,25 +532,43 @@ def _get_previous_ti(self, session=None):
if not previous_scheduled_date:
return None
- return TaskInstance(task=self.task,
- execution_date=previous_scheduled_date)
+ return TaskInstance(task=self.task,
execution_date=previous_scheduled_date)
dr.dag = dag
- if dag.catchup:
- last_dagrun = dr.get_previous_scheduled_dagrun(session=session)
+ if dag.catchup is False or state is not None or
dag.schedule_interval is None:
Review comment:
OK this is actually a bit more readable:
```
# We always ignore schedule in dagrun lookup when `state` is given or
`schedule_interval is None`.
# For legacy reasons, when `catchup=True`, we use
`get_previous_scheduled_dagrun` unless `ignore_schedule`.
ignore_schedule = state is not None or dag.schedule_interval is None
if dag.catchup is True and not ignore_schedule:
last_dagrun = dr.get_previous_scheduled_dagrun(session=session)
else:
last_dagrun = dr.get_previous_dagrun(session=session, state=state)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
