potiuk commented on code in PR #22754:
URL: https://github.com/apache/airflow/pull/22754#discussion_r862381219
##########
airflow/models/taskinstance.py:
##########
@@ -2069,15 +2069,27 @@ def get_rendered_template_fields(self, session: Session
= NEW_SESSION) -> None:
setattr(self.task, field_name, rendered_value)
self.task = task
return
+
try:
- self.render_templates()
+ # Task was never executed. Initialize RenderedTaskInstanceFields
+ # to render template and mask secrets. Set MASK_SECRETS_IN_LOGS
+ # to True to enable masking similar to task run.
+ original_value = settings.MASK_SECRETS_IN_LOGS
+ settings.MASK_SECRETS_IN_LOGS = True
Review Comment:
This one LGTM and fixes the not-nice behaviour @ashb @uranusjr - are you ok
with that one too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
