[
https://issues.apache.org/jira/browse/AIRFLOW-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858250#comment-16858250
]
ASF GitHub Bot commented on AIRFLOW-4737:
-----------------------------------------
villasv commented on pull request #5383: [AIRFLOW-4737] Increase and document
celery queue name limit
URL: https://github.com/apache/airflow/pull/5383
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4737
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [X] Here are some details about my PR, including screenshots of any UI
changes:
As described in the relevant issue and commit body, 50 characters is too
conservative, as 100 might as well be. SQS names can be 80 characters long,
which served as anchor for picking the next multiple of 50 that would suffice.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
This change should be transparent and have no effect on existing features.
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [X] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Column queue on task_instance table limit of 50 chars is too low
> ----------------------------------------------------------------
>
> Key: AIRFLOW-4737
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4737
> Project: Apache Airflow
> Issue Type: Improvement
> Components: models
> Affects Versions: 1.10.3
> Reporter: Victor Villas Bôas Chaves
> Assignee: Victor Villas Bôas Chaves
> Priority: Minor
>
> I tried to use an SQS queue named
> "airtest-AirflowStack-FW7GGJK59W9-Tasks-BL0L2W6F5OKF" as message broker, but
> the Scheduler fails to work because the queue name is 51 characters long.
> Why this huge queue name? SQS queue names are automatically generated by
> CloudFormation, and it's best practice to let it do so. Also, when using
> nested stacks, the inner stack also has its name automatically generated and
> appended to the master stack.
> So in short, my master stack is called "airtest" and the queue resource
> "Tasks" (which I believe are quite reasonably sized), but that huge name is
> what you end up in the end. Therefore the use case for longer queue names is
> there.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
