ashb commented on a change in pull request #5382: [AIRFLOW-4741] Include Sentry
for Airflow
URL: https://github.com/apache/airflow/pull/5382#discussion_r291546453
##########
File path: airflow/www/static/js/connection_form.js
##########
@@ -62,6 +62,12 @@ $(document).ready(function () {
'login': 'Username',
}
},
+ sentry: {
+ hidden_fields:['host', 'schema', 'login', 'password', 'port', 'extra'],
+ relabeling: {
+ 'conn_id': 'dsn'
Review comment:
That doesn't seem right - conn_id is a name to lookup the connection by
(i.e. `sentry_default` or similar).
Sentry has an API key right? If so that should be stored in the password
field, or the entire dsn should be in the `host` field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
