repl-chris opened a new pull request, #23462:
URL: https://github.com/apache/airflow/pull/23462

   DagRun links in the UI to `/graph` can currently be broken if you have 
several runs starting at (basically) the same time. The UI control that airflow 
uses for base_date only has per-second resolution (it loses everything 
sub-second), so to account for that the current implementation defaults 
base_date to exec_date rounded up to the nearest second. The problem occurs 
when several other dagruns were triggered in that rounded second - those other 
dagruns are loaded first (up to `num_runs`) so it's possible the requested 
dagrun does not even get loaded.  I know it sounds like an uncommon scenario 
but it actually happens to us a lot, as we have several processes that kick off 
many dagruns at the same time.  
   
   This PR maintains the existing rounding behavior for the base_date UI 
control, but uses the requested exec_date for the database query when the 
base_date has been rounded. This way the requested dagrun will always be the 
first record returned, even when base_date has been rounded up.
   
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragement file, named `{pr_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to