bbovenzi commented on PR #23392: URL: https://github.com/apache/airflow/pull/23392#issuecomment-1117375331
2 more UX issues outside of the react-query grid data stuff: 1. If a dagrun or task instance is currently selected, we apply a filter, and that selection is no longer visible the side panel goes blank. Let's add a check to useSelection to clear the selection if it is out of range? 2. I know I said to just highlight the task states instead of filtering them. I realized that I was a bit wrong here. Looking at graph view, hovering over a state in the legend will highlight tasks. We should have the Grid do the same. I think it might be best to pull that out into its own PR. Have this PR focus on dag run filtering. And then after those 2 PRs, we can do real task instance filtering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
