ashb commented on code in PR #23456:
URL: https://github.com/apache/airflow/pull/23456#discussion_r865961282
##########
airflow/www/static/js/grid/components/Table.jsx:
##########
@@ -187,28 +187,30 @@ const Table = ({
})}
</Tbody>
</ChakraTable>
- {totalEntries > data.length && (
+ {(canPreviousPage || canNextPage) && (
<Flex alignItems="center" justifyContent="flex-start" my={4}>
<IconButton
variant="ghost"
onClick={handlePrevious}
disabled={!canPreviousPage}
aria-label="Previous Page"
+ data-testid="previous"
Review Comment:
I'm not a huge fan of (read I actively dislike) having to "polute" the code
to support testing like this. Can't we get by the already existing aria-label
instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
