potiuk commented on PR #23556: URL: https://github.com/apache/airflow/pull/23556#issuecomment-1120178990
cc; @Bowrna @edithturn - FYI. the usual step in development process is that when things grow, we need to take a look at what we have and reshufs hifle/refactor things around to cleanup/standardize/commonalize. We got to the point when there were slightly different approaches in a few places and some decisions about structuring the code and package structure have to be revised. This is that kind of change. I looked from the top and tried to determine which classes/packages/methods are actually coupled and should be put together and which are probably unnecessarily put together because they are decoupled really and only accidentally grouped together with others. Also what helps in such project that we do not have too many "deep nesting" in packages - especially if different part of the code tree have different "depth". This change is the result of such review - it practically only reshuffles code around without changing any functionality - but the resulted structure is way more "intutitive" - usually when you modify a functionality you will have to modify one module or package only and things that are coupled and likely modified together are actually put together (for example you can see that required and optional args became fields of BuildCIParams/BuildProdParams because they are tightly coupled. You might want to take a look at some of the decisions I made there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
