potiuk commented on PR #23562: URL: https://github.com/apache/airflow/pull/23562#issuecomment-1120271387
CC: @Bowrna @edithturn - this one also includes a nice refactor of the "Build Params" - since I needed to change some internal set of methods and attributes on those, it ended up with a lot of duplication, so I decided to introduce a common super-class (_CommonBuildParams) where I extracted a lot of common attributes and methods - this way we have a lot less of duplicated code and much smaller Build*Params classes. I also sorted alphabetically all the attributes - making it easier to find what I am looking for :) BTW. Using IDEs like IntelliJ with refactoring tools is really helpful with those kinds of changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
