This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-3-test in repository https://gitbox.apache.org/repos/asf/airflow.git
commit 967859cf5850c82838c3bd266ecd8a547cde22f9 Author: Brent Bovenzi <[email protected]> AuthorDate: Thu Apr 28 14:39:35 2022 -0400 Use run_id for ti.mark_success_url (#23330) (cherry picked from commit a5f9df5c35645eeebb980e9288cd42dc7ac2cc54) --- airflow/models/taskinstance.py | 3 +-- tests/models/test_taskinstance.py | 3 ++- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/airflow/models/taskinstance.py b/airflow/models/taskinstance.py index 7ae7ff9536..123b4ddea3 100644 --- a/airflow/models/taskinstance.py +++ b/airflow/models/taskinstance.py @@ -803,13 +803,12 @@ class TaskInstance(Base, LoggingMixin): @property def mark_success_url(self): """URL to mark TI success""" - iso = quote(self.execution_date.isoformat()) base_url = conf.get('webserver', 'BASE_URL') return base_url + ( "/confirm" f"?task_id={self.task_id}" f"&dag_id={self.dag_id}" - f"&execution_date={iso}" + f"&dag_run_id={quote(self.run_id)}" "&upstream=false" "&downstream=false" "&state=success" diff --git a/tests/models/test_taskinstance.py b/tests/models/test_taskinstance.py index d104e79835..e53b52e11b 100644 --- a/tests/models/test_taskinstance.py +++ b/tests/models/test_taskinstance.py @@ -1312,7 +1312,8 @@ class TestTaskInstance: ) assert query['dag_id'][0] == 'dag' assert query['task_id'][0] == 'op' - assert pendulum.parse(query['execution_date'][0]) == now + assert query['dag_run_id'][0] == 'test' + assert ti.execution_date == now def test_overwrite_params_with_dag_run_conf(self, create_task_instance): ti = create_task_instance()
