This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 8f181c1034 wasb hook: user defaultAzureCredentials instead of
managedIdentity (#23394)
8f181c1034 is described below
commit 8f181c10344bd319ac5f6aeb102ee3c06e1f1637
Author: sanjayp <[email protected]>
AuthorDate: Mon May 9 02:42:26 2022 +0530
wasb hook: user defaultAzureCredentials instead of managedIdentity (#23394)
Co-authored-by: Sanjay Pillai <sanjaypillai11 [at] gmail.com>
---
airflow/providers/microsoft/azure/hooks/wasb.py | 8 ++++----
tests/providers/microsoft/azure/hooks/test_wasb.py | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/airflow/providers/microsoft/azure/hooks/wasb.py
b/airflow/providers/microsoft/azure/hooks/wasb.py
index 7ade4b401a..0bcd9952fc 100644
--- a/airflow/providers/microsoft/azure/hooks/wasb.py
+++ b/airflow/providers/microsoft/azure/hooks/wasb.py
@@ -29,7 +29,7 @@ field (see connection `wasb_default` for an example).
from typing import Any, Dict, List, Optional
from azure.core.exceptions import HttpResponseError, ResourceExistsError,
ResourceNotFoundError
-from azure.identity import ClientSecretCredential, ManagedIdentityCredential
+from azure.identity import ClientSecretCredential, DefaultAzureCredential
from azure.storage.blob import BlobClient, BlobServiceClient, ContainerClient,
StorageStreamDownloader
from airflow.exceptions import AirflowException
@@ -46,7 +46,7 @@ class WasbHook(BaseHook):
passed to the `BlockBlockService()` constructor. For example, authenticate
using a SAS token by adding {"sas_token": "YOUR_TOKEN"}.
- If no authentication configuration is provided, managed identity will be
used (applicable
+ If no authentication configuration is provided, DefaultAzureCredential
will be used (applicable
when using Azure compute infrastructure).
:param wasb_conn_id: Reference to the :ref:`wasb connection
<howto/connection:wasb>`.
@@ -151,8 +151,8 @@ class WasbHook(BaseHook):
# Fall back to old auth (password) or use managed identity if not
provided.
credential = conn.password
if not credential:
- credential = ManagedIdentityCredential()
- self.log.info("Using managed identity as credential")
+ credential = DefaultAzureCredential()
+ self.log.info("Using DefaultAzureCredential as credential")
return BlobServiceClient(
account_url=f"https://{conn.login}.blob.core.windows.net/";,
credential=credential,
diff --git a/tests/providers/microsoft/azure/hooks/test_wasb.py
b/tests/providers/microsoft/azure/hooks/test_wasb.py
index de65645df6..b258c50ced 100644
--- a/tests/providers/microsoft/azure/hooks/test_wasb.py
+++ b/tests/providers/microsoft/azure/hooks/test_wasb.py
@@ -22,7 +22,7 @@ import json
from unittest import mock
import pytest
-from azure.identity import ManagedIdentityCredential
+from azure.identity import DefaultAzureCredential
from azure.storage.blob import BlobServiceClient
from airflow.exceptions import AirflowException
@@ -140,7 +140,7 @@ class TestWasbHook:
def test_managed_identity(self):
hook = WasbHook(wasb_conn_id=self.managed_identity_conn_id)
assert isinstance(hook.get_conn(), BlobServiceClient)
- assert isinstance(hook.get_conn().credential,
ManagedIdentityCredential)
+ assert isinstance(hook.get_conn().credential, DefaultAzureCredential)
@pytest.mark.parametrize(
argnames="conn_id_str, extra_key",
