ashb commented on code in PR #22976:
URL: https://github.com/apache/airflow/pull/22976#discussion_r868196898
##########
tests/executors/test_kubernetes_executor.py:
##########
@@ -504,6 +505,39 @@ def test_try_adopt_task_instances(self,
mock_adopt_completed_pods, mock_adopt_la
mock_adopt_completed_pods.assert_called_once()
assert reset_tis == [] # This time our return is empty - no TIs to
reset
+
@mock.patch('airflow.executors.kubernetes_executor.KubernetesExecutor.adopt_launched_task')
+
@mock.patch('airflow.executors.kubernetes_executor.KubernetesExecutor._adopt_completed_pods')
+ def test_try_adopt_task_instances_manual_runs(self,
mock_adopt_completed_pods, mock_adopt_launched_task):
Review Comment:
"manual" is the wrong name here - elsewhere in the code base that commonly
refers to a manual dag run, but the scheduler still handles the queuing etc.
But here your are not (I think) talking about a manual dag run, but a run
action performed on a single TaskInstance, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
