mrshu commented on issue #5276: [AIRFLOW-4414] AWSAthenaOperator: Push 
QueryExecutionID to XCom
URL: https://github.com/apache/airflow/pull/5276#issuecomment-500108040
 
 
   @feluelle Sorry it took me this long to get back to this.
   
   I've added a test as you suggested and also refactored the 
`AWSAthenaOperator`'s test suite a bit:
   - the Athena query ID is now stored in a separate constant, so that it can 
be easily compared in tests
   - the Athena query ID is now a random UUID rather than `'1234'`
   - the test suite now contains a simple DAG, which is necessary for testing 
XComs
   
   If you would like to try the changes out yourself, it should be as easy as 
running
   
   ```bash
   ./run_unit_tests.sh 
tests.contrib.operators.test_aws_athena_operator:TestAWSAthenaOperator -s 
--logging-level=DEBUG
   ```
   
   Please do let me know if there is anything else I can do to get this to 
"mergeable" state.
   
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to