BasPH commented on a change in pull request #5361: [AIRFLOW-4670] Make
airflow/example_dags Pylint compatible
URL: https://github.com/apache/airflow/pull/5361#discussion_r291817403
##########
File path: airflow/example_dags/example_skip_dag.py
##########
@@ -30,21 +32,31 @@
# Create some placeholder operators
class DummySkipOperator(DummyOperator):
+ """Dummy operator which always skips the task."""
+
ui_color = '#e8b7e4'
def execute(self, context):
raise AirflowSkipException
-def create_test_pipeline(suffix, trigger_rule, dag):
- skip_operator =
DummySkipOperator(task_id='skip_operator_{}'.format(suffix), dag=dag)
- always_true = DummyOperator(task_id='always_true_{}'.format(suffix),
dag=dag)
- join = DummyOperator(task_id=trigger_rule, dag=dag,
trigger_rule=trigger_rule)
- final = DummyOperator(task_id='final_{}'.format(suffix), dag=dag)
+def create_test_pipeline(suffix, trigger_rule, dag_):
+ """
+ Instantiate a number of operators for the given DAG.
Review comment:
I remember you telling my about this yes, forgot once again.
I tried searching for the exact problem but couldn't find it, I thought you
said the docs don't get rendered correctly without the whitespace? E.g. the
BashOperator.execute() pydoc is written without whitespace but the docs look
okay:
https://airflow.apache.org/_api/airflow/operators/bash_operator/index.html#airflow.operators.bash_operator.BashOperator.execute.
Could you let me know the exact issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
