potiuk commented on PR #23631:
URL: https://github.com/apache/airflow/pull/23631#issuecomment-1123225357

   > If you need me to raise PR to make the entries in google change log with 
PR numbers let me know :) I can do that also after we merge this one
   
   Actually. I just tried to attempt it and there is a problem. The assumption 
is (and this is somethign we automatically check) that each PR# from the commit 
is mentioned at most once in the Changelog. And we actually NEED to have 
numbers there so that we can can easily find  where the changes come from (so 
this more information for the committers than users).
   When the changelog is put the current way, We'd have to put each PR in 
multiple entries. 
   
   And if we do, we get:
   
   ```
   Duplicate changelog entries found for 
airflow/providers/google/CHANGELOG.rst: 
   ['23251', '23230', '23261', '23261', '23261', '23261', '23261', '23231', 
'23250', '23250', '23250', '23250', '23252', '23269', '23269', '23328']
   ``` 
   
   So I think getting the list of commits with PR# below the "user facing" 
changes is the best way - but if you think you can do it better - feel free :).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to