jedcunningham commented on code in PR #23635:
URL: https://github.com/apache/airflow/pull/23635#discussion_r870206064
##########
airflow/www/templates/airflow/dags.html:
##########
@@ -80,15 +80,27 @@
{% for m in dashboard_alerts %}
{{ show_message(m.message, m.category) }}
{% endfor %}
- {% for original_table_name, moved_table_name in migration_moved_data_alerts
%}
- {% call show_message(category='error', dismissible=false) %}
- Airflow found incompatible data in the <code>{{ original_table_name
}}</code> table in the
- metadatabase, and has moved them to <code>{{ moved_table_name }}</code>
during the database migration
- to upgrade. Please inspect the moved data to decide whether you need to
keep them, and manually drop
- the <code>{{ moved_table_name }}</code> table to dismiss this warning.
Read more about it
+ {% if migration_moved_data_alerts %}
+ {% call show_message(category='warning', dismissible=false) %}
+ While upgrading the metadatabase, Airflow had to move some bad data in
order to apply new constraints.
+ The moved data can be found in the following tables:<br>
+ <table>
+ <tr>
+ <th style="padding-right:10px">Source table</th>
+ <th>Moved data</th>
+ </tr>
+ {% for original_table_name, moved_table_name in
migration_moved_data_alerts %}
+ <tr>
+ <td style="padding-right:10px"><code>{{ original_table_name
}}</code></td>
+ <td><code>{{ moved_table_name }}</code></td>
+ </tr>
+ {% endfor %}
+ </table>
+ Please inspect the moved data to decide whether you need to keep them,
and manually drop
+ the <code>moved</code> tables to dismiss this warning. Read more about it
Review Comment:
```suggestion
the moved tables to dismiss this warning. Read more about it
```
##########
airflow/www/templates/airflow/dags.html:
##########
@@ -80,15 +80,27 @@
{% for m in dashboard_alerts %}
{{ show_message(m.message, m.category) }}
{% endfor %}
- {% for original_table_name, moved_table_name in migration_moved_data_alerts
%}
- {% call show_message(category='error', dismissible=false) %}
- Airflow found incompatible data in the <code>{{ original_table_name
}}</code> table in the
- metadatabase, and has moved them to <code>{{ moved_table_name }}</code>
during the database migration
- to upgrade. Please inspect the moved data to decide whether you need to
keep them, and manually drop
- the <code>{{ moved_table_name }}</code> table to dismiss this warning.
Read more about it
+ {% if migration_moved_data_alerts %}
+ {% call show_message(category='warning', dismissible=false) %}
+ While upgrading the metadatabase, Airflow had to move some bad data in
order to apply new constraints.
+ The moved data can be found in the following tables:<br>
+ <table>
+ <tr>
+ <th style="padding-right:10px">Source table</th>
+ <th>Moved data</th>
+ </tr>
Review Comment:
I feel like we should have "table" in here too, however I'm struggling to
come up with something I like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
