kaxil commented on code in PR #22917:
URL: https://github.com/apache/airflow/pull/22917#discussion_r870559786
##########
airflow/dag_processing/manager.py:
##########
@@ -514,6 +514,10 @@ def _deactivate_stale_dags(self, session=None):
if deactivated:
self.log.info("Deactivated %i DAGs which are no longer
present in file.", deactivated)
+ for dag_id in to_deactivate:
+ SerializedDagModel.remove_dag(dag_id)
+ self.log.info("Deleted DAG %s in serialized_dag table",
dag_id)
+
Review Comment:
Yup I know that :) -- What I more meant was do you think we should combine
that or not run that now in Dag Processing Manager now that we have the changes
in this PR? Don't see a point in having both the methods when one in the PR is
superset of the other.
##########
airflow/dag_processing/manager.py:
##########
@@ -514,6 +514,10 @@ def _deactivate_stale_dags(self, session=None):
if deactivated:
self.log.info("Deactivated %i DAGs which are no longer
present in file.", deactivated)
+ for dag_id in to_deactivate:
Review Comment:
Docstrings of the function should be updated to reflect this change too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
