potiuk commented on PR #21877: URL: https://github.com/apache/airflow/pull/21877#issuecomment-1124825674
No problem @KevinYang21 - Agree. One thing here, since this is quite "sensitive" change (this is the main reason why we have not merged it before 2.3.0 and had no time to dive deep as there is still some focus on getting 2.3.1 out - fixing some "blocker" teething problems with 2.3.0 - is this possible (or maybe you have already done so) to run this change in AirBnB staging environment with some heavy'ier load (I guess you are also planning to migrate to 2.3+ at some point, so maybe the main version of airflow after those few changes ported from your earlier "fork" (as I understand) is already good enough to be tested at bigger scale at AirBnB to catch potential races etc. ? I think that would alleviate a number of concerns about the change here - i know for a fact those kind of "deep core" changes are heavily tested by Ash and team in the Astro test/qa/staging environments rather than only via unit tests, so having some "thumbsup" from AriBnb using the main version of Airflow with those changes included at some point in time would be a great thing :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
