potiuk commented on code in PR #23675: URL: https://github.com/apache/airflow/pull/23675#discussion_r871604290
########## scripts/ci/pre_commit/pre_commit_check_pre_commit_hooks.py: ########## @@ -25,7 +25,7 @@ import sys from pathlib import Path -sys.path.insert(0, str(Path(__file__).parent.absolute())) # make sure common_precommit_utils is imported +sys.path.insert(0, str(Path(__file__).parent.resolve())) # make sure common_precommit_utils is imported Review Comment: Same as above. It does not hurt. Call it being overcautiious but I do not want to exercise any extra mental power to remember where I can use relative path and where it is not safe. Using absolute path is always safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
