skyboi1233 commented on PR #23711:
URL: https://github.com/apache/airflow/pull/23711#issuecomment-1128215964
My. Account is not secure and changes are being mad with out my promises to
my accounts any way we can fix this issues
Sent from Yahoo Mail for iPhone
On Monday, May 16, 2022, 5:42 PM, Jed Cunningham ***@***.***> wrote:
@jedcunningham commented on this pull request.
We no longer need the DAGs mounted in the scheduler if this is enabled,
right?
In chart/templates/dagprocessor/dag-processor-deployment.yaml:
> +## Airflow Dag Processor Deployment
+#################################
+{{- if semverCompare ">=2.3.0" .Values.airflowVersion }}
+{{- if .Values.dagProcessor.enabled }}
+{{- $nodeSelector := or .Values.dagProcessor.nodeSelector
.Values.nodeSelector }}
+{{- $affinity := or .Values.dagProcessor.affinity .Values.affinity }}
+{{- $tolerations := or .Values.dagProcessor.tolerations .Values.tolerations
}}
+{{- $topologySpreadConstraints := or
.Values.dagProcessor.topologySpreadConstraints
.Values.topologySpreadConstraints }}
+{{- $securityContext := include "airflowSecurityContext" (list .
.Values.dagProcessor) }}
+kind: Deployment
+apiVersion: apps/v1
+metadata:
+ name: {{ .Release.Name }}-dag-processor
+ labels:
+ tier: airflow
+ component: dag-processor
That second one sounds good to me.
In chart/templates/_helpers.yaml:
> @@ -653,6 +664,14 @@ Create the name of the cleanup service account to use
airflow jobs check --job-type TriggererJob --hostname $(hostname)
{{- end }}
+{{define "dag_processor_liveness_check_command"}}
+ - sh
+ - -c
+ - |
+ CONNECTION_CHECK_MAX_COUNT=0 AIRFLOW__LOGGING__LOGGING_LEVEL=ERROR exec
/entrypoint \
+ airflow jobs check --job-type SchedulerJob --hostname $(hostname)
In the meantime, you can probably leave off the job type and it'll still
work.
In tests/charts/test_basic_helm_chart.py:
> @@ -97,6 +97,78 @@ def test_basic_deployments(self):
"TEST-LABEL"
), f"Missing label TEST-LABEL on {k8s_name}. Current labels:
{labels}"
+ def test_basic_deployment_with_standalone_scheduler(self):
+ k8s_objects = render_chart(
+ "TEST-BASIC",
+ values={
+ "chart": {
+ 'metadata': 'AA',
+ },
+ 'labels': {"TEST-LABEL": "TEST-VALUE"},
+ "fullnameOverride": "TEST-BASIC",
+ "dagProcessor": {'enabled': True},
I think being disabled by default at this point makes sense.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID:
***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
