turbaszek commented on code in PR #23767:
URL: https://github.com/apache/airflow/pull/23767#discussion_r875510449
##########
airflow/providers/snowflake/hooks/snowflake.py:
##########
@@ -290,7 +290,7 @@ def run(
autocommit: bool = False,
parameters: Optional[Union[Sequence[Any], Dict[Any, Any]]] = None,
handler: Optional[Callable] = None,
- ):
+ ) -> Optional[List]:
Review Comment:
Is there any use case for empty `sql` argument? Maybe it would be better to
raise `ValueError` instead of doing unnecessary connection opening. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
