dstandish commented on PR #22086: URL: https://github.com/apache/airflow/pull/22086#issuecomment-1130107301
@potiuk, ideally I'd _like_ to merge this one first, just since @raphaelauv went through the trouble of making it. The thing that gives me hesitation is backcompat. If we release this before https://github.com/apache/airflow/pull/20578, then there when https://github.com/apache/airflow/pull/20578 is released there will be some behavior changes that users would experience. For one, with this PR, using K8s hook would mean that core k8s settings would not be considered (in https://github.com/apache/airflow/pull/20578 they _are_ in order to make a smooth transition). And the other is that in this one, TCP keepalive logic is not there, but in https://github.com/apache/airflow/pull/20578 it will be. If these two PRs would go out in the same release, then that's fine because there's no backcompat concern. If they won't then probably it's not a good idea. FWIW I think https://github.com/apache/airflow/pull/20578 is just about ready. I _just_ got all tests passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
