thcidale0808 commented on code in PR #23567: URL: https://github.com/apache/airflow/pull/23567#discussion_r877477543
########## tests/providers/databricks/sensors/test_databricks.py: ########## @@ -0,0 +1,172 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +import unittest +from unittest import mock +from airflow.providers.databricks.sensors.databricks import \ + (DatabricksDeltaTableChangeSensor, DatabricksPartitionTableSensor) +from databricks.sql.types import Row + + +DEFAULT_CONN_ID = 'databricks_default' + + +class TestDatabricksDeltaTableChangeSensor(unittest.TestCase): + + @mock.patch('airflow.providers.databricks.sensors.databricks.DatabricksSqlHook') + def test_exec_success_sensor_find_new_events(self, db_mock_class): + """ + Test the sensor when find a new event from the Databricks Delta Table + """ + + sensor = DatabricksDeltaTableChangeSensor( + task_id='run_now', + databricks_conn_id='databricks_default', + table='table_test', + timestamp='2022-05-07 21:24:58.680358' Review Comment: Fixed ########## airflow/providers/databricks/sensors/databricks.py: ########## @@ -0,0 +1,140 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +"""This module contains Databricks sensors.""" + +from typing import Dict, Any, List, Optional, Sequence, Tuple +from datetime import datetime +from airflow.sensors.base import BaseSensorOperator +from airflow.providers.databricks.hooks.databricks_sql import DatabricksSqlHook + + +from airflow.utils.context import Context + + +class DatabricksBaseSensor(BaseSensorOperator): + + def __init__( + self, + *, + databricks_conn_id: str = DatabricksSqlHook.default_conn_name, + http_path: Optional[str] = None, + sql_endpoint_name: Optional[str] = None, + session_configuration=None, + http_headers: Optional[List[Tuple[str, str]]] = None, + catalog: Optional[str] = None, + schema: Optional[str] = None, + client_parameters: Optional[Dict[str, Any]] = None, + **kwargs, + ) -> None: + """Creates a new ``DatabricksSqlSensor``.""" + super().__init__(**kwargs) + self.databricks_conn_id = databricks_conn_id + self._http_path = http_path + self._sql_endpoint_name = sql_endpoint_name + self.session_config = session_configuration + self.http_headers = http_headers + self.catalog = catalog + self.schema = schema + self.client_parameters = client_parameters or {} + + def _get_hook(self) -> DatabricksSqlHook: + return DatabricksSqlHook( + self.databricks_conn_id, + http_path=self._http_path, + session_configuration=self.session_config, + sql_endpoint_name=self._sql_endpoint_name, + http_headers=self.http_headers, + catalog=self.catalog, + schema=self.schema, + **self.client_parameters, + ) + + +class DatabricksPartitionTableSensor(DatabricksBaseSensor): + """ + Waits for a partition to show up in Databricks. + + :param table: The name of the table to wait for, supports the dot + notation (my_database.my_table) + :param partition: The partition clause to wait for. + :param database: The name of the database in Databricks. It uses 'default' if nothing is provided + :param databricks_conn_id: Reference to the :ref:`Databricks connection <howto/connection:databricks>`. + """ + template_fields: Sequence[str] = ( + 'database', + 'table', + 'partition', + ) + + def __init__(self, *, + databricks_conn_id: str, + table: str, + partition: str, + database: Optional[str] = 'default', + **kwargs: Any): + super().__init__(**kwargs) + self.databricks_conn_id = databricks_conn_id + self.table = table + self.partition = partition + self.database = database + + def poke(self, context: Context) -> bool: + hook = self._get_hook() + _, result = hook.run(f'SHOW PARTITIONS {self.database}.{self.table}') + record = result[0] if result else {} + return self.partition in record + + +class DatabricksDeltaTableChangeSensor(DatabricksBaseSensor): + """ + Waits for Delta table event + + :param table: The name of the table to wait for, supports the dot + notation (my_database.my_table) + :param timestamp: The timestamp that will be used to filter new events. Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
