pierrejeambrun commented on PR #23678: URL: https://github.com/apache/airflow/pull/23678#issuecomment-1132221045
I just updated the PR. Jinja `tojson` function is sorting keys automatically in the returned json. We can add `flask_app.config['JSON_SORT_KEYS'] = False`, but that is kind of intrusive. Or we can just for this particular use case, declare the `STATE_COLORS` global object directly sorted. This way the sort with the json does not create a change compare to the raw STATE_COLORS obj given to jinja globals. I chose this approach first. The drawback is that it could bring back inconsistencies between the two pages if something add colors to this object breaking the sort of the declared key. Finally we could also manually sort of both ends this object, but it seems kind of overkill. Added the `no_status` state with hovering effect as well, and a few tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
