josh-fell commented on code in PR #23597:
URL: https://github.com/apache/airflow/pull/23597#discussion_r878629643
##########
airflow/models/connection.py:
##########
@@ -208,8 +208,8 @@ def get_uri(self) -> str:
"""Return connection in URI format"""
if '_' in self.conn_type:
self.log.warning(
- f"Connection schemes (type: {str(self.conn_type)}) "
- f"shall not contain '_' according to RFC3986."
+ "Connection schemes (type: %s) shall not contain '_' according
to RFC3986.",
+ str(self.conn_type),
Review Comment:
🤦 Yep, thanks.
##########
airflow/models/dagrun.py:
##########
@@ -790,7 +790,7 @@ def
_emit_true_scheduling_delay_stats_for_finished_state(self, finished_tis: Lis
if true_delay.total_seconds() > 0:
Stats.timing(f'dagrun.{dag.dag_id}.first_task_scheduling_delay', true_delay)
except Exception as e:
- self.log.warning(f'Failed to record first_task_scheduling_delay
metric:\n{e}')
+ self.log.warning('Failed to record first_task_scheduling_delay
metric:\n%s', e)
Review Comment:
Brilliant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
