potiuk commented on code in PR #23841:
URL: https://github.com/apache/airflow/pull/23841#discussion_r878740961
##########
.github/workflows/ci.yml:
##########
@@ -309,8 +309,6 @@ jobs:
with:
python-version: ${{ needs.build-info.outputs.defaultPythonVersion }}
if: needs.build-info.outputs.inWorkflowBuild == 'true'
- - run: ./scripts/ci/install_breeze.sh
- if: needs.build-info.outputs.inWorkflowBuild == 'true'
- name: "Retrieve DEFAULTS from the _initialization.sh"
Review Comment:
I think we can remove that one entirely. It's copied from `build.yml` but it
is only needed there. We only do that in `build.yml` to make sure that we will
use values defined in the PR and not in main (build.yml by default uses
workflow and scripts from main and not from PR for security reasons). Actually
I plan to remote that part completely once we convert all the scripts to Python
as in Python it can (and will be) done much easier so maybe let's not touch it
:).
##########
.github/workflows/ci.yml:
##########
@@ -392,7 +392,7 @@ jobs:
awk 'BEGIN{FS="="} {print $3}' | sed s'/["}]//g')
echo "DEFAULT_CONSTRAINTS_BRANCH=${DEFAULT_CONSTRAINTS_BRANCH}" >>
$GITHUB_ENV
DEBIAN_VERSION=$(grep "export DEBIAN_VERSION"
scripts/ci/libraries/_initialization.sh | \
- cut -d "=" -f 3 | sed s'/["}]//g')
+ awk 'BEGIN{FS="="} {print $3}' | sed s'/["}]//g')
Review Comment:
Why not :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
