uranusjr commented on PR #23662:
URL: https://github.com/apache/airflow/pull/23662#issuecomment-1135359777
Instead of inheriting `CronDataIntervalTimetable` directly, I would prefer
the common logic be extracted out to a superclass, which both timetable clases
inherit.
I feel this class should also schedule tasks differently. As described in
AIP-39, a common use case for this kind of timetables is for tasks to run at
the end of each weekday (say 5pm). This means the cron expression should
express the _end_ of a data interval, instead of the beginning like
`CronDataIntervalTimetable`. In other words, `PlainCronTimetable("0 5 * *
1-5")` triggers a DAG run at 5pm on each Monday through Friday, with each run
covering the interval between the triggering time of this and the previous run.
This would mean we need more different logic between this class and
`CronDataIntervalTimetable`.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
