[ 
https://issues.apache.org/jira/browse/AIRFLOW-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859930#comment-16859930
 ] 

ASF subversion and git services commented on AIRFLOW-4731:
----------------------------------------------------------

Commit ff71e2abcc8e8ffa0d705412401a1583880eafb9 in airflow's branch 
refs/heads/v1-10-test from Gordon Ball
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=ff71e2a ]

[AIRFLOW-4731] Fix GCS hook with google-storage-client 1.16 (#5368)

google-storage-client 1.16 introduced a breaking change where the
signature of client.get_bucket changed from (bucket_name) to
(bucket_or_name). Calls with named arguments to this method now fail.
This commit makes all calls positional to work around this.

(cherry picked from commit 201e67100c200d38dbc3cd530cd04dd31bf91d7f)


> GCS hook broken by storage client 1.16
> --------------------------------------
>
>                 Key: AIRFLOW-4731
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4731
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: gcp
>    Affects Versions: 1.10.3
>            Reporter: Gordon Ball
>            Priority: Major
>             Fix For: 1.10.4
>
>
> Upgrading google-cloud-storage to 1.16 (allowed by the current spec in 
> setup.py, ~= 1.14) causes breakage.
> Upstream change 
> [https://github.com/googleapis/google-cloud-python/pull/7856|https://github.com/googleapis/google-cloud-python/pull/7856/files]
>  altered the argument name for `get_bucket(...)`, so existing calls which use 
> `get_bucket(bucket_name=...)` now cause an error. Comments on that pull 
> acknowledge that this shouldn't have been done in a minor version.
> The simple fix would be to pin `google-cloud-storage == 1.15`, but this is 
> probably fairly easy to fix call sites for future compatibility.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to