parvezmkhan opened a new issue, #23910: URL: https://github.com/apache/airflow/issues/23910
### Apache Airflow version 2.2.2 ### What happened When creating salesforce hook like below get sf = SalesforceHook(salesforce_conn_id="test_sf") Get below TypeError You must provide login information or an instance and token This is test salesforce domain. User name and password are set correctly in Airflow connection but security token is not filled. I expect the connection to setup without error ### What you think should happen instead Changing https://github.com/apache/airflow/blob/1d53bec0618c042de5cd05801b0c1fe015e6b4f8/airflow/providers/salesforce/hooks/salesforce.py#L144 to below works, i.e. connection is established security_token=extras["extra__salesforce__security_token"] or '', ### How to reproduce Setup salesforce connection in airflow with * user name, password and no security token * domain : test * API version : 54.0 ### Operating System macOS 11.2.3 ### Versions of Apache Airflow Providers apache-airflow-providers-salesforce 3.3.0 simple-salesforce 1.11.4 ### Deployment Virtualenv installation ### Deployment details _No response_ ### Anything else _No response_ ### Are you willing to submit PR? - [X] Yes I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
