uranusjr commented on code in PR #23915:
URL: https://github.com/apache/airflow/pull/23915#discussion_r881790085
##########
airflow/operators/sql.py:
##########
@@ -467,6 +467,218 @@ def push(self, meta_data):
self.log.info("Log from %s:\n%s", self.dag_id, info)
+def _get_failed_tests(checks):
+ failed_tests = []
+ for check, check_values in checks.items():
+ if not check_values["success"]:
+ failed_tests.append(
+ f"\tCheck: {check}, "
+ f"Pass Value: {check_values['pass_value']}, "
+ f"Result: {check_values['result']}\n"
+ )
+ return failed_tests
Review Comment:
But this string does not seem to be used at all. Maybe it should simply be
like this?
```python
def _all_success(checks):
return all(values["success"] for values in checks.values())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
