villasv commented on issue #5383: [AIRFLOW-4737] Increase and document celery 
queue name limit
URL: https://github.com/apache/airflow/pull/5383#issuecomment-500418703
 
 
   I'm sorry if it seemed like I was considering it inconvenient and a bad 
idea, it's not. It's negligible effort, but I do think it's also negligible 
value.
   
   While migrations are indeed part of the codebase, they're definitely not in 
the scope of standard software development standards. You said you didn't want 
to lower the boundaries, but that's sort of what happened: modules starting 
with numbers are now allowed inside _all_ the codebase, despite this being 
acceptable only inside migrations. That's why I said migrations should use a 
different set of pylint configurations (or none at all, but the first is 
better). 
   
   I completely agree with all your motives, despite this docstring in 
particular being totally unrelated to the issue itself and IMO better as a line 
comment like it was before. But it's OK. I think git/JIRA is the right place to 
document the value decision anyway. 
   
   I see the doscstring currently being merged is not there because it's a good 
docstring, it's there because I need pylint to pass. This means pylint needs 
adjustments to become more useful.
   
   Will rebase and push.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to