mik-laj commented on code in PR #23961:
URL: https://github.com/apache/airflow/pull/23961#discussion_r884329197
##########
airflow/providers/apache/beam/operators/beam.py:
##########
@@ -91,6 +92,13 @@ def __get_dataflow_pipeline_options(
pipeline_options[job_name_key] = job_name
if self.dataflow_config.service_account:
pipeline_options["serviceAccount"] =
self.dataflow_config.service_account
+ if self.dataflow_support_impersonation and
self.dataflow_config.impersonation_chain:
+ if isinstance(self.dataflow_config.impersonation_chain, list):
+ pipeline_options["impersonateServiceAccount"] = ",".join(
+ self.dataflow_config.impersonation_chain
+ )
+ else:
+ pipeline_options["impersonateServiceAccount"] =
self.dataflow_config.impersonation_chain
Review Comment:
The behavior of apache beam can change from version to version, so I'd
rather not add extra parameters when we don't need it. Especially when this is
a new parameter and may not be stable yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
