uranusjr commented on code in PR #23510:
URL: https://github.com/apache/airflow/pull/23510#discussion_r884375089
##########
airflow/security/permissions.py:
##########
@@ -66,14 +66,15 @@
DAG_ACTIONS = {ACTION_CAN_READ, ACTION_CAN_EDIT, ACTION_CAN_DELETE}
-def resource_name_for_dag(dag_id):
- """Returns the resource name for a DAG id."""
- if dag_id == RESOURCE_DAG:
- return dag_id
+def resource_name_for_dag(root_dag_id: str) -> str:
+ """Returns the resource name for a DAG id.
- if dag_id.startswith(RESOURCE_DAG_PREFIX):
- return dag_id
-
- # To account for SubDags
- root_dag_id = dag_id.split(".")[0]
+ Note that since a sub-DAG should follow the permission of its
+ parent DAG, you should pass ``DagModel.root_dag_id`` to this function,
+ for a subdag. A normal dag should pass the DagModel.dag_id
Review Comment:
```suggestion
for a subdag. A normal dag should pass the ``DagModel.dag_id``.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
