uranusjr commented on code in PR #23248:
URL: https://github.com/apache/airflow/pull/23248#discussion_r884397458
##########
airflow/providers/google/cloud/operators/functions.py:
##########
@@ -459,4 +459,8 @@ def execute(self, context: 'Context'):
)
self.log.info('Function called successfully. Execution id %s',
result.get('executionId'))
self.xcom_push(context=context, key='execution_id',
value=result.get('executionId'))
+
+ # HTTP function returns a JSON response, making it available in xcom
+ if 'result' in result:
+ self.xcom_push(context=context, key='function_response',
value=result.get('result'))
return result
Review Comment:
Isn’t the value already available here with an extra `["result"]` call?
Making it available again under a different key seems to provide minimal
benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
