uranusjr commented on code in PR #23888:
URL: https://github.com/apache/airflow/pull/23888#discussion_r884427431
##########
airflow/config_templates/config.yml:
##########
@@ -2246,6 +2246,13 @@
type: string
example: ~
default: "offset"
+ - name: index_patterns
+ description: |
+ Comma separated list of index patterns to use when searching for logs
(default: `_all`).
+ version_added: 2.3.0
+ type: string
+ example: something-*
+ default: "_all"
Review Comment:
If this is a special case in Elastic, I am OK to use `_all` as the default.
The main motivation behind using `*` is you don’t need a special case in
`_validate_search_targets` for it. But if we need to handle `_all` specially
anyway, the difference is minimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
