potiuk opened a new pull request, #24023:
URL: https://github.com/apache/airflow/pull/24023

   Apparently pushing multi-platform images when building cache on CI
   has some problems recently, connected with ghcr.io being more
   vulnerable to race condition described in this issue:
   
   https://github.com/containerd/containerd/issues/5978
   
   Apparently when two, different platform layers are pushed about
   the same time to ghcr.io, the error
   "cannot reuse body, request must be retried" is generated.
   
   However we actually do not even need to build the multiplatform
   latest images because as of recently we have separate cache for each
   platform, and the ghcr.io/:latest images are not used any more
   not even for docker builds. We we always build images rather than
   pull and we use --from-cache for that - specific per platform. The only
   image pulling we do is when we pull the :COMMIT_HASH images in CI- but
   those are single-platform images (amd64) and even if we add tests for
   arm, they will have different tag.
   
   Hopefully we can still build release images without causing the
   race condition too frequently - this is more likely because when
   we build images for cache we use machines with different performance
   characteristics and the same layers are pushed at different times
   from different platforms.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragement file, named `{pr_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to