potiuk commented on code in PR #24018:
URL: https://github.com/apache/airflow/pull/24018#discussion_r884755254


##########
airflow/models/mappedoperator.py:
##########
@@ -201,7 +201,7 @@ def _expand(self, **mapped_kwargs: "Mappable") -> 
"MappedOperator":
         from airflow.operators.empty import EmptyOperator
 
         validate_mapping_kwargs(self.operator_class, "expand", mapped_kwargs)
-        prevent_duplicates(self.kwargs, mapped_kwargs, fail_reason="mapping 
already partial")
+        prevent_duplicates(self.kwargs, mapped_kwargs, fail_reason="unmappable 
or already specified")

Review Comment:
   ```suggestion
           prevent_duplicates(self.kwargs, mapped_kwargs, 
fail_reason="unmappable or already specified (see 
https://airflow.apache.org/docs/apache-airflow/stable/concepts/dynamic-task-mapping.html#mapping-with-non-taskflow-operators
 )")
   ```
   
   Don't we want to direct the user to the exact place in the docs where more 
context and details is explained? I think that would be an empathetic bahaviour 
towards the users who see it for the very first time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to